Repository navigation
Fix theta preamble count for legacy single-item images - #774
Merged
leerho merged 1 commit intoOct 1, 2026
Merged
Conversation
tisonkun
pushed a commit
to apache/datasketches-tck
that referenced
this pull request
Oct 4, 2026
* Track .sk snapshots even when a global gitignore excludes them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore: update Java snapshots to datasketches-java main (059b5a9) Move the Java snapshot pin from 3a1bf7f to 059b5a9, the merge of apache/datasketches-java#774, and regenerate the Java snapshots. Deterministic changes: - HLL_6 and HLL_8 compact images set the compact flag (java#761). - Empty tuple and AoS compact images write a zero seed hash. - Adds frequent_long_purged and frequent_string_purged (java#770). All other modifications are probabilistic snapshots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore: update C++ snapshots to datasketches-cpp master (16d4ea6) Move the C++ snapshot pin from fe0261a to 16d4ea6 and regenerate the C++ snapshots. Deterministic changes: - Single-item compact theta images set the single-item flag (cpp#526). - Adds frequent_long_purged and frequent_string_purged (cpp#529). - Removes the 27 aos_*_cpp.sk snapshots: the C++ array-of-strings tuple sketch was reverted (cpp#537) because its key hashing is incompatible with Java (cpp#533). All other modifications are probabilistic snapshots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #773.
Historical C++ theta single-item images may omit the optional single-item flag. Java accepts these images, but
PreambleUtil.preambleToString()previously derived the implied count from that flag and displayedCurrentCount: 0.This change derives the one-preamble-long count from the authoritative empty flag while continuing to display the serialized single-item flag unchanged.
The regression test clears only the flag on a valid single-item image and verifies:
SINGLE_ITEM: falseaccurately reflects the historical bytesCurrentCount: 1accurately reflects the retained itemValidation:
mvn -t /private/tmp/jdk25-toolchains.xml -Dtest=org.apache.datasketches.theta.PreambleUtilTest test(8 tests)mvn -t /private/tmp/jdk25-toolchains.xml test(2,287 tests)git diff --check