Repository navigation
Conversation
The TCK moved its snapshots from serialization/<lang>/snapshots to serialization_test_data/<lang>_generated_files (apache/datasketches-tck#14), the same layout this repository uses. Match the new archive paths, strip one fewer path component, and pin the TCK at e748b0a, its current main. The serde-compat workflow's Java entry passed `java` to the download script, which only accepts cpp and go. The check_java_files profile generates its own snapshots before checking them, so skip the download for that entry instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
tools/download_serialization_test_data.shfor the new TCK layout and moves its pin to the current TCKmain.Changes
serialization/<lang>/snapshots/toserialization_test_data/<lang>_generated_files/(Use the serialization_test_data/<lang>_generated_files layout datasketches-tck#14), the same layout this repository uses. The script now matches the new archive paths and uses--strip-components=3instead of4.TCK_REVISIONmoves fromd363b12(July) toe748b0a, the current TCKmain.serde-compat.yml. The Java matrix entry passedjavato the download script, which only acceptscppandgo, so that job failed. Thecheck_java_filesprofile generates its own snapshots before checking them, so the download step is now skipped for that entry.Verification
e748b0a.mvn test -P check_go_filespasses.mvn test -P check_java_filespasses.mvn test -P check_cpp_fileshas one known failure:AodSketchCrossLanguageTest.checkCpp, "Incompatible Seed Hashes. 0, 93cc".About the known failure
It's a real C++/Java incompatibility that the old pin hid. It is not caused by this change.
0, to match Java'sEmptyCompactSketch. In C++, array-of-doubles (AoD) is built on the generic tuple sketch, so empty AoD sketches now write0too.0.d363b12, so this test never saw it until now.Standard
mvn clean testis unaffected. The failure only shows up when the cross-language profiles run.🤖 Generated with Claude Code