Conversation
…le change The pull_request paths filters of test.yml and test-e2e.yml list 'go.mod', 'go.sum' and 'Makefile' without a directory prefix. GitHub matches these patterns against the repository root only, so changes to backend/go.mod, backend/go.sum or backend/Makefile never trigger the unit-test and e2e jobs. Dependabot gomod PRs (e.g. apache#9192) therefore become mergeable without a single compile or test run, and the go.mod tidiness guard added in apache#9179 is skipped exactly where it matters. Prefix the patterns with '**/' so they match at any depth, including the repository root.
aws-sdk-go v1 reached end-of-support on 2025-07-31. Its final release, v1.55.8, marks every package as deprecated, so staticcheck reports SA1019 for each import in plugins/kiro. This turns the lint job red for the Dependabot go-minor-patch group (apache#9192) and for every future gomod update, although nothing in the code changed. Exclude exactly this finding (SA1019 for aws-sdk-go, only under plugins/kiro/) instead of pinning the dependency or adding nolint comments, so the remaining technical debt stays visible in one place. The exclusion is meant to be removed once the plugin is migrated to aws-sdk-go-v2 (tracked in a separate issue).
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small fixes so that Dependabot's
gomodPRs (first one: #9192) areactually tested and can turn green:
fix(ci): run unit/e2e tests whenbackend/go.mod,go.sumorMakefilechange. Thepull_request.pathsfilters oftest.ymlandtest-e2e.ymllistgo.mod,go.sumandMakefilewithout a directoryprefix. GitHub matches those against the repository root only, so a diff
that touches only
backend/go.mod/backend/go.sum— i.e. every Dependabotgomod PR — never triggers
unit-test,e2e-mysqlore2e-postgres. Onbuild(deps): bump the go-minor-patch group in /backend with 26 updates #9192 only
lintand a few metadata checks ran; the 26 updates were nevercompiled or tested, and the
go mod tidyguard from fix(build): make go mod tidy work on a fresh clone #9179 was skipped.The patterns are now prefixed with
**/(which also matches the root).build(lint): tolerate the aws-sdk-go v1 deprecation in the kiroplugin. aws-sdk-go v1 is end-of-support since 2025-07-31; its last
release v1.55.8 (pulled in by build(deps): bump the go-minor-patch group in /backend with 26 updates #9192) marks every package deprecated, so
staticcheckreports 11×SA1019inplugins/kiro. The exclusion islimited to that check, that import path and that plugin, and carries a
comment to remove it after the migration to aws-sdk-go-v2, which is tracked
in [Refactor][Kiro] Migrate the kiro plugin from aws-sdk-go v1 to aws-sdk-go-v2 #9195 and [Refactor][Build] Remove the end-of-support aws-sdk-go v1 from backend/go.mod #9196.
No production code changes.
Does this close any open issues?
No. Unblocks #9192. Related: #9195, #9196.
Verification
--path-mode=absas in CI) onupstream/main+ this PR + build(deps): bump the go-minor-patch group in /backend with 26 updates #9192: 0 issues. Same tree with theunchanged
.golangci.yaml: exactly the 11SA1019findings from the CIrun on build(deps): bump the go-minor-patch group in /backend with 26 updates #9192.
ok, no failures(incl.
plugins/kiro/...);go mod tidyon a cleanmocks/tree leavesgo.mod/go.sumunchanged.release-9192-base=upstream/main+ this PR, head = base + the build(deps): bump the go-minor-patch group in /backend with 26 updates #9192 commit, so the PR difftouches only
backend/go.modandbackend/go.sum(verify: #9192 on top of paths-filter + lint fix (throwaway) DoDiODev/devlake#61, closed): 9/9 green —
test (ubuntu-latest)(incl. Check go.mod is tidy without generated mocks and Unit tests),
e2e-mysql,e2e-postgres,lint,plus the metadata checks. Without fix 1 the first three would not have
been triggered for this diff at all.
Other Information
I can't exercise the kiro plugin against real AWS resources, so I kept the
code untouched and only made the existing deprecation explicit; the actual
migration is left to the plugin author (see the issues).