Repository navigation
FINERACT-2973: Fix ad-hoc loan search on PostgreSQL - #6701
Open
Aarti-panchal01 wants to merge 1 commit into
Open
Aarti-panchal01 wants to merge 1 commit into
Aarti-panchal01 wants to merge 1 commit into
Conversation
Author
|
The first CI run failed on PostgreSQL shard 6 before any test ran: Maven Central did not return |
POST /search/advance failed on PostgreSQL with a syntax error because the query in SearchReadServiceImpl aliased a column as 'count' in single quotes, which PostgreSQL does not accept (MySQL and MariaDB do). Alias it without quotes; the row mapper already reads the column as count. Assisted-By: Claude Opus 5.5
Aarti-panchal01
force-pushed
the
fix-adhoc-search-count-alias
branch
from
October 20, 2026 20:56
2b6b108 to
411936f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
POST /search/advance (the ad-hoc loan search behind the Fund Mapping page) returns a 500 on PostgreSQL. The query aliases a column as
'count'in single quotes, which PostgreSQL rejects (syntax error at or near "'count'"); MySQL and MariaDB accept it. The alias is now unquoted (a.cnt as count), which works on all three, and the row mapper already reads the column ascount.Added a unit test in
SearchReadServiceImplTestthat checks the generated SQL has no quoted alias. It fails on develop and passes with this change.Tested on a local Fineract with PostgreSQL 18: the request returned a 500 before the change and the grouped loans after it.
JIRA: https://issues.apache.org/jira/browse/FINERACT-2973
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!