Skip to content

FINERACT-2974: Apply the name and active flag when updating a hook - #6702

Open
Aarti-panchal01 wants to merge 1 commit into
apache:developfrom
Aarti-panchal01:fix-hook-update-name-active
Open

Aarti-panchal01 wants to merge 1 commit into
apache:developfrom
Aarti-panchal01:fix-hook-update-name-active

Conversation

@Aarti-panchal01

Copy link
Copy Markdown

Description

PUT /hooks/{hookId} with a new displayName or isActive returns 200 and lists them under changes, but the hook keeps its old name and active flag (checked in m_hook). HookWritePlatformServiceImpl.updateHook adds both to the changes map but never sets them on the Hook entity, unlike events and config. It also reported both as changed (and saved) when the request left them out, because it compared null with the stored value.

The hook now gets the new name and active flag when the request provides them, and they are left alone when it does not.

Added HookWritePlatformServiceImplTest: one test renames and deactivates a hook, one sends neither field. Both fail on develop and pass with this change.

Found while building the Manage Hooks pages of the Mifos X React web app (MXWAR-235).

JIRA: https://issues.apache.org/jira/browse/FINERACT-2974

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
  • I followed the AI Policy.

HookWritePlatformServiceImpl.updateHook listed displayName and isActive
in the response changes but never set them on the hook, so renaming or
deactivating a hook through PUT /hooks/{hookId} returned 200 and did
nothing. Set them when the request provides them, and leave them alone
when it does not.

Assisted-By: Claude Opus 5.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant