Repository navigation
HTTPCORE-801: Use long for unsigned 32-bit HTTP/2 values - #723
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
Use long for HTTP/2 settings values and error codes defined as unsigned 32-bit integers.
ok2c
reviewed
Oct 7, 2026
| <exclude>@org.apache.hc.core5.annotation.Internal</exclude> | ||
| <exclude>org.apache.hc.core5.testing.reactive.ReactiveTestUtils</exclude> | ||
| <exclude>org.apache.hc.core5.testing.framework.*</exclude> | ||
| <!-- HTTPCORE-801: uint32 HTTP/2 values returned as long --> |
Member
There was a problem hiding this comment.
@arturobernalg I do not think this is a good idea. We should not do that until 6.0. I am not in favor of this change. Quite strongly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use long to represent HTTP/2 settings values and error codes defined as unsigned 32-bit integers.
Keep narrower protocol values such as initial window size and maximum frame size as int, and preserve the 32-bit wire representation when encoding and decoding frames.
This also preserves the full range of unknown HTTP/2 error codes and settings values without interpreting values with the high bit set as negative Java integers.