Repository navigation
fix(client-go): allow propertyless edge labels - #807
Merged
Merged
Conversation
- accept nil and empty edge label properties - cover request encoding and required fields - explain typed API HTTP status checks
This was referenced Oct 11, 2026
Pengzna
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The Go client rejected an edge label without properties before sending the request, even though Server accepts that schema.
EdgeLabel.Createnow forwards nil or empty properties while keeping name, source label and target label required.The related README guidance explains how to check HTTP status after transport and JSON errors, including a valid JSON error response with
err == nil.Validation
Targeted HTTP contract tests and race checks,
go build ./...andmake allpassed using existing dependencies. Before/after probes against a real native RocksDB Server verified HTTP 201 creation for nil and empty properties, HTTP 200 readback with an empty property list, and fixture cleanup. Three independent source reviews found no actionable issue.The same branch passed the org PR checks, including Go validation against the configured candidate Server and official release 1.7, fixture checks, license headers and the module summary.
Org validation: hugegraph#60
Documentation
Doc - Done: Go client English and Chinese README.
Paired website documentation: ASF #516. Coordinate the documentation merge with this code change.