Repository navigation
test: run MapPropertyTest.testGetPropertyTypeOfStringElements - #6847
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
The test was added without @test in d3a0d32, so it never ran. Its name says string elements but it used Integer values, so it now uses String values, which a MapProperty stores as StringProperty. MapProperty.getPropertyType() gets the null check that CollectionProperty.getPropertyType() already has, so the constructor no longer relies on getBlankProperty() catching a NullPointerException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MapPropertyTest.testGetPropertyTypeOfStringElementswas added without@Testin d3a0d32 (2018), so it never ran. Its name says string elements but it usedIntegervalues, so it now usesStringvalues, which aMapPropertystores asStringProperty.MapProperty.getPropertyType()also gets the null checkCollectionProperty.getPropertyType()already has, so the constructor no longer relies ongetBlankProperty()catching aNullPointerException.How Has This Been Tested?
./gradlew :src:core:testand./gradlew classes style; the enabled test fails ifgetPropertyType()ignores the map's values.