Repository navigation
Fix flaky CI: TestSchedulerWithTimer margin, Oracle JDK matrix, missing PGP keys - #6848
Merged
vlsi merged 3 commits intoOct 30, 2026
Merged
Conversation
The tearDown duration check measured from the setUp sampler, so the 2s margin also had to absorb thread start/stop, a forced GC and Groovy compilation. Slow macOS CI workers exceeded it (7338ms > 7000ms). Raise the margin to 5s: a 10s limit still clearly detects the scheduler failing to interrupt the 20s pauses (Bugs 60797, 60049). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
download.oracle.com no longer serves the "latest" JDK 17 and 21 builds (the no-fee license for them has ended), so matrix jobs that picked oracle with Java 21 failed in "Set up Java" with a 404 checksum error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rebelwithoutacause
changed the title
verification-metadata.xml trusts the AssertJ, Azure SDK, gRPC and Jetty signing keys, but they were absent from verification-keyring.keys, so Gradle had to download them from key servers at build time. When the servers were unreachable, dependency verification failed in CI: Artifact was signed with key '4DB5EA09F2E3C800' but it wasn't found in any key server so it couldn't be verified Add the keys (fingerprints match the trusted ids) so verification no longer depends on key server availability. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rebelwithoutacause
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
batchTestSchedulerWithTimerfailed on macOS / JDK 25 in CI run 40919458824:The tearDown check measures time from the setUp sampler, so the 2s margin over the 5s scheduler duration also has to cover setUp thread exit, the forced GC before the main groups start, thread start and join, the tearDown group starting, and Groovy compilation of the check script. On slow CI workers this overhead can go past 2s.
The engine itself behaves correctly:
JMeterThread.delay()andTestActioncap their sleeps at the scheduler end time viaTimerService.adjustDelay.Change
The expected
.csv/.xmloutputs are unchanged.CI: Oracle JDK only for Java 25+
The CI run for this PR then failed in "Set up Java 21, oracle" (
Checksum not available for: https://download.oracle.com/java/21/latest/jdk-21_windows-x64_bin.zip). Oracle no longer serves the "latest" builds of JDK 17 and 21 because their no-fee license has ended, and both the archive and.sha256URLs now return 404. JDK 25 is still served.matrix.mjsnow pairsoracleonly with Java 25 and later. In 200 generated matrices, Oracle came up 44 times, always with Java 25.Build: add missing keys to the verification keyring
Another job then failed in dependency verification for
:src:dist:nodeSetup, withArtifact was signed with key '4DB5EA09F2E3C800' but it wasn't found in any key server so it couldn't be verifiedand the same error for other POMs.verification-metadata.xmltrusts the AssertJ (0CC0B712FEE75827), Azure SDK (8D5DB0BAA89FE87B), gRPC (D9C565AA72BA2FDD) and Jetty (4DB5EA09F2E3C800) signing keys, but none of them were inverification-keyring.keys. That forced a key server download, which fails when the servers are unreachable. The four keys are now in the keyring at their sorted positions. Their fingerprints match the trusted IDs, and no existing entries changed.Testing
./gradlew :src:dist-check:batchTestSchedulerWithTimerpasses locally (Windows, JDK 21).🤖 Generated with Claude Code