Repository navigation
Conversation
neilcsmith-net
approved these changes
Oct 7, 2026
neilcsmith-net
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks!
How much slower? Nothing too concerning?
Contributor
Author
|
I would say a lot a few minutes. We do two reports one txt(for human)) on xml (for report processing) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt the build to be compatible with last Apache RAT.
It take more time than on .15 to do the task. The report.txt is much more verbose than .15 not sure we shoud keep it.
Used mostly there:
https://ci-builds.apache.org/job/Netbeans/job/netbeans-license/lastSuccessfulBuild/artifact/nbbuild/build/
Parsing adjusted in our RatReportTask because of XML grammar changes.
Ignore 3 files in installer to avoid error because it handle GPL header.
Rat .18 start with following. More detailled. sh and xml can be shown as Binaries
Rat .15