Repository navigation
Conversation
sciabarracom
self-requested a review
October 20, 2026 16:32
sciabarracom
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.9.0 runtime-preloader integration test assumes that every configured image starts with
apache/. The shipped catalog also containsopenwhisk/images, so valid preloader output fails the test in the original 0.9.0 CI run 38893750250.Compare the complete multiset of preloader container names and images against the configured default runtimes and always-preloaded
:sysruntimes, across registries. This retains checks for missing runtimes, wrong images/tags, wrong identities and duplicates. Runtime-selection code and the runtime catalog are unchanged.Validation:
:sysruntime, and deliberately corrupt or remove parser output to verify rejection.task itestrunner's exit-code behavior. The workflow change is identical in both independent PRs; after both scripts are updated, neither failure can be downgraded to a warning.This PR is independent of the FerretDB correction and of the Redis/etcd/Milvus security backports. Current-head CI: Check run 39296649683 passed on
1b0888a: all 21 regression tests, the unit-test step and the final integration gate passed.tests/kind/runtimes_preloader_test.ipyreports OK. The only remaining warning is the unchanged originaltests/kind/ferretdb_test.ipytest, addressed by the separate companion PR. The two patches were also combined locally: all 29 regression tests passed, and the shared CI gate passed 9 scenarios, including rejection of either failed corrected test after both fixes are present.