Repository navigation
enh: rework form resubmit via self-dispatch rather than a network-call - #2900
Merged
Merged
Conversation
github-actions
Bot
added
java
Contributor
Author
|
For now, this is full of AI slop, but it (at least tests pass) works?. Needs lots of refactoring and simplification, so the code actually makes some sense |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…sting/jakarta/ee/servlets/ExceptionServlet.java
lprimak
force-pushed
the
remove-resubmit-netcall
branch
from
October 1, 2026 03:35
ff97a29 to
78782a3
Compare
Contributor
Author
|
Got rid of lots of AI slop for now, time for real review and manual refactoring. |
lprimak
marked this pull request as ready for review
October 10, 2026 18:46
Contributor
Author
|
Ran in production for a few days, no regressions found, functionality works in real applications. |
lprimak
requested review from
bmarwell,
boris-petrov,
fpapon,
jbonofre and
steinarb
October 10, 2026 18:48
steinarb
reviewed
Oct 13, 2026
| } | ||
| response.addCookie(cookieToDelete); | ||
| @NonNull String cookieName, boolean useHostPrefix) { | ||
| response.addCookie(newCookie(servletContext, cookieName, "tbd", 0, useHostPrefix)); |
Contributor
There was a problem hiding this comment.
Some warnings here... not sure if they are valid or already taken care of...?
Contributor
Author
There was a problem hiding this comment.
I dont see any warnings, can you paste them in? Where are you getting the warnings?
steinarb
reviewed
Oct 13, 2026
| /** | ||
| * Replayed responses are captured and only applied to the browser on demand | ||
| */ | ||
| @ExtendWith(MockitoExtension.class) |
Contributor
There was a problem hiding this comment.
👍 For tests of new classes
Contributor
|
>>>> Lenny Primak ***@***.***>:
I dont see any warnings, can you paste them in? Where are you getting the warnings?
The warnings were in the PR close to where I made the comment.
|
Contributor
Author
|
Are you talking about GH advanced security / CodeQL warnings? They are all dismissed as false positives because they are :) |
Contributor
|
>>>> Lenny Primak ***@***.***>:
lprimak left a comment (apache/shiro#2900)
Are you talking about GH advanced security / CodeQL warnings? They are all dismissed as false positives because they are :)
Ah, ok!
I will approve the PR then.
|
steinarb
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internals of data loss prevention / data save functionality is redone without a network call.
Ran security model tests with LLMs, with only improvements reported (no regressions)
TODO: update docs on the website.This has been done.Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager,where you replace
#XXXwith the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXXif merging the PR should close a related issue.mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.