Repository navigation
WW-3792 test(core): pin css_xhtml checkbox left-label wrappers to match other controls - #2041
Merged
Merged
Conversation
…ch other controls Under css_xhtml every control wraps its label and control in <div> for labelPosition="top" and <span> otherwise. Pins that a checkbox with labelPosition="left" uses the same wrapper elements as a textfield. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lukaszlenart
marked this pull request as ready for review
October 17, 2026 14:03
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to WW-3792
Summary
WW-3792 reports that under
css_xhtmla<s:checkbox labelposition="left">wraps its label and control in<span>, while other controls use<div>. That is not checkbox-specific: everycss_xhtmlcontrol uses<div>only forlabelPosition="top"(the default) and<span>otherwise — seecontrolheader-core.ftl/controlheader.ftl. A textfield atleftrenders the same spans, and did so in 2.3.1.2 as well.This PR is test-only. It renders a textfield and a checkbox, both
css_xhtmlwithlabelPosition="left", and asserts theirwwlbl_*andwwctrl_*wrappers use the same element, so the checkbox template stays in step with the other controls.Verification
CheckboxTest: 22/22 pass on current code.css_xhtml/checkbox.ftlchanged from<spanto<div, the new test fails withexpected:<[span]> but was:<[div]>.🤖 Generated with Claude Code