Repository navigation
Conversation
(cherry picked from commit b1a3640)
…es of references and code blocks (cherry picked from commit cdf499c)
…ent renders (cherry picked from commit fa56ba7)
…onents, prop docs, no memo (cherry picked from commit b4b8ed4)
…er Assistant files (cherry picked from commit 50321b6)
…cus to a footnote and drop useDeferredValue (cherry picked from commit bf28065)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Depends on #5570. Image-policy changes only.
Addresses the image-loading follow-up raised in #5570.
Model-generated Markdown can include image URLs containing notebook data. Loading these images automatically sends a request to the destination without user interaction.
This PR replaces automatic image loading with a Load image button. Before loading, the reader can review the image description, destination host, full URL, and a warning that the request may transmit information from the answer. Only HTTP(S) image URLs are supported.
Approval is specific to each image in an answer. Unchanged images retain approval during streaming, including when a reference definition gains a title. Changing the destination or removing and restoring an image requires fresh approval.
What type of PR is it?
Bug Fix
What is the Jira issue?
How should this be tested?
From
zeppelin-web-angular/projects/zeppelin-react, run:npm test -- src/entities/assistant/ui/MarkdownAnswer.spec.tsx npm run typecheck npm run build:storybook npm run test:storybook -- markdown-answer-images.spec.mjsFor manual verification, run
npm run storybookand open Assistant / MarkdownAnswer:contentcontrol, remove an approved image and restore the same Markdown. Confirm that it requires approval again.Questions