Repository navigation
fix: report the real Actor name length limit - #1484
Merged
Merged
Conversation
The max-length error said "a maximum of 30 characters" while the check compares against ACTOR_NAME.MAX_LENGTH, which is 63. Both length messages now interpolate the constants so they cannot drift again. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
l2ysho
added
bug
apify-factory
left a comment
apify-factory
left a comment
Contributor
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved: the pull request changed during the review
The pull request moved to 87b84abcf while d20a76b62 was being reviewed, so nothing was approved; request @apify-factory again for the new content.
| check | result |
|---|---|
| Static gates | ✅ 16/16 |
| Review findings | ✅ none |
| Reviewer escalation | ✅ none |
Juror 1 — claude-sonnet-5-5, adversarial |
✅ approve |
Why it was not auto-approved
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed d20a76b62 · workflow run
Contributor
Author
|
@apify-factory rerun |
apify-factory
approved these changes
Oct 22, 2026
apify-factory
left a comment
apify-factory
left a comment
Contributor
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Apify Factory auto approved ✅ — nothing to see here, and that is the good news
Every gate passed, and neither the reviewer nor a juror found anything a human needs to look at.
Approval locked to 58cdc48cf · workflow run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Lets test apify-factory auto approve on this PR.
What changed
validateActorNameinsrc/lib/utils.ts:The Actor name must be a maximum of 30 characters long.→`The Actor name must be at most ${ACTOR_NAME.MAX_LENGTH} characters long.`3→${ACTOR_NAME.MIN_LENGTH}Why
ACTOR_NAME.MAX_LENGTHfrom@apify/constsis 63, not 30. A user with a 40-character name was rejected by a message that told them a limit the code does not enforce. The min-length value was correct but carried the same drift risk, so both now read from the constants.Notes for the reviewer
grep -rn "characters long"hits only these two lines.apify init --yesfailure path surfaces these messages more often.pnpm run lint && pnpm run format && pnpm run build && pnpm run test:localall pass (687 passed, 4 skipped).update-docsrun needed: no flag, arg, description, or command changed.🤖 Generated with Claude Code