Repository navigation
test: deflake test_stall_waits_for_in_flight_work - #2355
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2355 +/- ##
==========================================
+ Coverage 94.10% 94.14% +0.03%
==========================================
Files 184 184
Lines 13647 13647
==========================================
+ Hits 12843 12848 +5
+ Misses 804 799 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
October 26, 2026 07:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_stall_waits_for_in_flight_workflaked on macOS / 3.11 (run) withDID NOT RAISE PersistentRateLimitError. The test used a 50-100 ms real-time backoff. On a slow runner it ran out before the crawler checked whether the domain was held back, so every attempt counted as an ordinary error, the request failed, and no stall was ever raised.The test now runs the throttler on a stopped clock, like
open_throttler_held_until_reclaimand #2331. Each reclaim moves the clock one backoff forward until the domain has been rate-limited longer thanmax_domain_stall. After that the clock stays put, so the request waits in its cooldown as a stalled domain and doesn't cycle intoMAX_HANDLER_CALLS.Local runs couldn't reproduce the flake on their own. Delaying
is_throttledby 120 ms reproduces the CI failure every time. With that delay the fixed test passes, and it passed 128 of 128 runs under CPU oversubscription. It still fails if the crawler raises a stall while a request is in flight.✍️ Drafted by Claude Code