Repository navigation
chore: raise dependency cooldown to 7 days - #592
Merged
Merged
Conversation
Raise the minimum release age to at least 7 days (pnpm, uv, Renovate) so newly published versions aren't installed until they've been public for a week. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
apify-factory
left a comment
apify-factory
left a comment
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.
| check | result |
|---|---|
| Static gates | ❌ 15/16 — file-extensions |
| Review findings | ✅ none |
| Reviewer escalation | ✅ none |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — a gate failed |
Why it was not auto-approved
Failed gates:
file-extensions: disallowed extension: impit-node/pnpm-workspace.yaml, impit-python/pyproject.toml, impit-python/uv.lock, renovate.json
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed 7053fca4a · workflow run
Member
|
Thank you @filakovsky ! I noticed the conversation on Slack - is this PR still something we want to do? I don't have any strong personal opinion myself. |
Contributor
Author
|
Hi @barjin, yes, it’s still worth it. Later we could decrease this limit back, but for now, let’s set it to 7 days, if you’re okay with that. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the dependency cooldown to at least 7 days for every package manager in this repo, so a newly published (and possibly compromised) version isn't installed until it has been public for a week.
Changes
impit-node/pnpm-workspace.yaml:minimumReleaseAge1440 → 10080 (24 hours → 7 days)impit-python/pyproject.toml:exclude-newer"1 day" → "7 days"renovate.json:minimumReleaseAge1 day → 7 daysLockfiles
impit-python/uv.lock: re-locked, because uv records the cooldown in the lockfile. These packages moved back to releases that are at least 7 days old:Notes
🤖 Generated with Claude Code