Repository navigation
Conversation
AppStack only guarded release != nil, so an empty release rewrote /latest/ to //. Masked today by upgrade.go's flag default. Add a table test asserting all eight TemplateURL implementations agree, plus an AST check that fails if a new TemplateURL type is not in the table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #269.
What:
AppStack.TemplateURLnow guardsrelease != nil && *release != "", matching the other seven stacks. Addsstacks/template_url_test.go: a table test over all eight implementations (nil /""/"canary"), plus an AST-based check that fails if any type declaringTemplateURLis missing from the table, so a ninth stack with the wrong guard can't slip in.Why: an empty release turned
/latest/into//, a URL CloudFormation rejects. Currently masked becausecmd/upgrade.goleaves the sharedreleaseflag var as"latest". Flag defaults are intentionally untouched.Before fix (
go test ./stacks -run TemplateURL):Only AppStack/empty_release failed; the other 23 cases passed.
After fix:
ok github.com/apppackio/apppack/stacks;make testexit 0.make fmt/make lintcan't run locally (golangci-lint built with go1.26, config targets 1.27.1); I rangofmton the changed files instead.