Repository navigation
Rename RobinBC to avoid naming conflict in moose framework - #19
Merged
Merged
Conversation
Contributor
Author
|
This passes the tests on my local Mac. |
smpark7
requested changes
Oct 23, 2026
| #include "IntegratedBC.h" | ||
|
|
||
| class RobinBC : public IntegratedBC | ||
| class VelocityRobinBC : public IntegratedBC |
Collaborator
There was a problem hiding this comment.
I think OutflowRobinBC is a more accurate name for this.
Contributor
Author
There was a problem hiding this comment.
Thanks. I will make the change.
smpark7
approved these changes
Oct 23, 2026
smpark7
left a comment
smpark7
left a comment
Collaborator
There was a problem hiding this comment.
CI is failing due to INL conda channel being down. I tested locally and it passes. I'm approving because it's a simple name change, and we want to propagate the change to Moltres and Zapdos which will run rounds of CIVET testing.
Contributor
Author
|
Thanks. I will push the submodule updates now in the two dependent apps. |
Contributor
Author
|
Two PRs with squirrel submodule update to its latest master banch have been pushed in Moltres and Zapdos. |
Collaborator
|
I can merge the Moltres PR once CIVET passes. You should ping someone else for the Zapdos PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for upcoming changes in MOOSE (idaholab/moose#34182). This can be merged first. Tag @lindsayad