Repository navigation
fix: reject hidden fields in derived filters - #466
Merged
zachdaniel merged 1 commit intoOct 30, 2026
Merged
Conversation
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hide_fields/show_fieldskeep a field out of responses, the OpenAPI filter schema, sparse fieldsets, includes and derived sort, but a derived filter can still reference it. Whether a record comes back then reveals the hidden value:filter[secret]=private, orfilter[secret][greater_than]=ato narrow it down. The same goes for hidden calculations and relationships, and for fields outside ashow_fieldsallowlist.filter_ref_transformer/0returnsnilfor a hidden field, andAsh.Filterfalls back to the name as given, which only checkspublic?. The transformer now maps a hidden field to a name that matches no field, so the filter fails withno_such_field, as it does for an unknown field. The fields that make up the JSON:APIidstay filterable, and filters built from a route's own path params opt out withfilter_ref_transformer(allow_hidden?: true).Contributor checklist
Leave anything that you believe does not apply unchecked.