Repository navigation
Fix conflicting evaluator scopes and add live regression cases - #2
Merged
Merged
Conversation
brianorwhatever
marked this pull request as ready for review
October 24, 2026 16:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REV rejected a correct function and matching execution observations because its prompts mixed whole-requirement completeness with per-item relevance. Each verdict now explicitly targets one criterion; source relationships use a separate policy that assesses contribution without demanding that every item prove the whole requirement.
The model, thresholds, evidence-class requirements, contradiction checks, and fail-closed aggregation remain unchanged. The evaluation suite now includes 14 executed cases across five domains, and its export fixture describes the actual function calls rather than an HTTP server it does not implement.
Validation: 33 local tests and syntax checks passed. Live evaluation matched all 20 criterion labels across 14 cases (five correct implementations approved; nine broken or unverifiable cases blocked). The unchanged evidence from TV PRs #23–#25 passed 20 of 23 criteria; three remain unverified and were not used for further prompt tuning. Results, limitations, exact evaluator commits, and run links are recorded in docs/evaluation.md and eval/results/2026-10-24-scoped.json.
Note
Fix conflicting evaluator scopes and add live regression challenge fixtures
policy.INSTRUCTIONSnow target one criterion only, and a newpolicy.RELATION_INSTRUCTIONSjudges a single evidence item against one criterion in policy.jsgate.requestBodynow scopes criterion questions to an explicit criterion state and evidence questions to a specific evidence item path with its own relation policy in gate.jschallengeFixturesin challenge-fixtures.jseval.runnow processes the six original fixtures plus eight challenge cases and still fails on any mismatch or error in run.jsroute(session)outputs instead of HTTP endpoint behavior in fixtures.jseval.taskcriteria no longer mention HTTP endpoints; requests now carry criterion and evidence target paths, verified in gate.test.jsMacroscope summarized ca0fb4d.