Repository navigation
Add the GitHub CI script for pull request builds - #108
Draft
jonathan343 wants to merge 1 commit into
Draft
jonathan343 wants to merge 1 commit into
jonathan343 wants to merge 1 commit into
Conversation
kuhe
reviewed
Oct 8, 2026
| --branch "$HEAD_REF" \ | ||
| --pr-number "$PR_NUMBER" \ | ||
| --run-id "$RUN_ID" | ||
| timeout-minutes: 45 |
Contributor
There was a problem hiding this comment.
maybe start at 120 so we aren't surprised by this later?
is this the total run time cap, or like an idle timeout?
kuhe
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a GitHub Actions workflow that runs our internal pull request build on every PR against
develop, so changes are checked before they merge.The workflow runs when a PR is opened, updated, or marked ready for review. The job is skipped for draft PRs and for PRs from forks, which can't assume the role. The role session and the step timeout are both 45 minutes. This matches the workflow added to smithy-python and already used in boto3, botocore, and aws-cli.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.