Skip to content

Upgrade to Kafka 4.4 - #497

Draft
philipp94831 wants to merge 5 commits into
masterfrom
feature/kafka-4.4
Draft

philipp94831 wants to merge 5 commits into
masterfrom
feature/kafka-4.4

Conversation

@philipp94831

Copy link
Copy Markdown
Member

No description provided.

@philipp94831 philipp94831 self-assigned this Oct 29, 2026
@philipp94831

Copy link
Copy Markdown
Member Author

@copilot implement tests for the new methods. See KStreamXTest for examples. There are already tests using GlobalKTable which you can adapt from

Co-authored-by: philipp94831 <2177801+philipp94831@users.noreply.github.com>

Copilot AI commented Oct 29, 2026

Copy link
Copy Markdown

@copilot implement tests for the new methods. See KStreamXTest for examples. There are already tests using GlobalKTable which you can adapt from

Added tests for all four GlobalKTable overloads using ValueJoinerWithStreamAndMappedKey, including named variants. Commit: fb39f1f. The focused test task could not reach compilation because the configured Maven host was unavailable.

};
try (final TestTopology<String, String> topology = app.startApp()) {
topology.input("table_input")
.add("bar", "baz");

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Can you use four different values for the input keys and values? foo, bar, baz, qux. Also below

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated all four overload tests to distinguish the stream key (foo), stream value (bar), mapped table key (baz), and table value (qux). Commit: 8e1c32a. The focused test task remains blocked before compilation by unavailable Maven dependencies.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Sorry, I didn't understand the api properly. Revert the last commit, the test was fine

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the last commit; the tests are restored to their prior values. Commit: 89745a9.

Co-authored-by: philipp94831 <2177801+philipp94831@users.noreply.github.com>
Co-authored-by: philipp94831 <2177801+philipp94831@users.noreply.github.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants