Skip to content

fix(L1): revert SuperchainConfig merger on v8.4.0 - #451

Merged
jackchuma merged 1 commit into
releases/v8.4.0from
fix/revert-432-v8.4.0
Oct 12, 2026
Merged

jackchuma merged 1 commit into
releases/v8.4.0from
fix/revert-432-v8.4.0

Conversation

@jackchuma

Copy link
Copy Markdown
Collaborator

What changed? Why?

Revert #432 on releases/v8.4.0 to restore separate SuperchainConfig pause management. This reverses the actual squash merge a0b8955a33e51733940f3424cf84abc0fae2c071 across contracts, interfaces, deployment configuration and tooling, tests, ABI/storage snapshots, and semver hashes.

Notes to reviewers

How has it been tested?

  • Restored existing behavioral tests rather than adding duplicate coverage. Focused pause/SystemConfig/deployment/affected-contract tests: 442 passed, 0 failed.
  • just test: 1237 passed, 0 failed, 1 skipped. forge test --match-test test_cannotReinitialize_succeeds: 2 passed.
  • just lint-check, just validate-spacers-no-build, forced source builds, just snapshots, just semver-lock, and just snapshots-check-no-build pass. Regeneration leaves the committed snapshots unchanged; whitespace checks pass.
  • Git comparisons confirm the changed-path set exactly matches the 54 paths from refactor(L1): merge SuperchainConfig into SystemConfig #432, nonoverlapping reverted files match its parent, and unrelated later files/semver entries remain unchanged. Overlapping portal/setup changes retain later release behavior.
  • Optional just lint-forge-tests-check-no-build and fresh-source just interfaces-check-no-build retain 21 and 18 historical findings, respectively. Offending first-party sources, missing interfaces, and tool/dependency pins were checked against the parent of refactor(L1): merge SuperchainConfig into SystemConfig #432. These baseline naming/interface repairs are outside this revert.
  • Forked live-upgrade tests were not run.

Generated with Toshi

This reverts commit a0b8955.

Restore separate SuperchainConfig pause management, deployment wiring, interfaces, tests, and source-built snapshots while retaining later release changes.

Use OptimismPortal2 6.0.1 to reverse the merger major bump and preserve the later smart-account patch increment.
@jackchuma
jackchuma marked this pull request as ready for review October 12, 2026 17:31
@jackchuma
jackchuma merged commit 8c21f6d into releases/v8.4.0 Oct 12, 2026
3 of 4 checks passed
@jackchuma
jackchuma deleted the fix/revert-432-v8.4.0 branch October 12, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant