Repository navigation
fix(L1): revert SuperchainConfig merger on v8.4.0 - #451
Merged
Merged
Conversation
This reverts commit a0b8955. Restore separate SuperchainConfig pause management, deployment wiring, interfaces, tests, and source-built snapshots while retaining later release changes. Use OptimismPortal2 6.0.1 to reverse the merger major bump and preserve the later smart-account patch increment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Revert #432 on
releases/v8.4.0to restore separateSuperchainConfigpause management. This reverses the actual squash mergea0b8955a33e51733940f3424cf84abc0fae2c071across contracts, interfaces, deployment configuration and tooling, tests, ABI/storage snapshots, and semver hashes.Notes to reviewers
releases/v8.4.0, notmain. Preserve unrelated release changes from Use generic names for AggregateVerifier intervals #444, add cobalt reports #446, chore: improve smart account handling #447, and refactor(L2): tighten BaseTime NatSpec and tests #449, including AggregateVerifier/BaseTime snapshots and semver entries. The ETHLockbox removal from fix(L1): bump semver for contracts changed since the last release #438/fix(L1): bump SystemConfig semver for the ETHLockbox removal #440 remains intact.superchainConfigGuardian/superchainConfigIncidentResponderdeploy keys.6.0.1: reverse the6.0.0to7.0.0merger bump in refactor(L1): merge SuperchainConfig into SystemConfig #432 while preserving the patch increment and smart-account behavior from chore: improve smart account handling #447. Regenerate semver hashes from fresh source builds rather than restoring stale hashes.How has it been tested?
just test: 1237 passed, 0 failed, 1 skipped.forge test --match-test test_cannotReinitialize_succeeds: 2 passed.just lint-check,just validate-spacers-no-build, forced source builds,just snapshots,just semver-lock, andjust snapshots-check-no-buildpass. Regeneration leaves the committed snapshots unchanged; whitespace checks pass.just lint-forge-tests-check-no-buildand fresh-sourcejust interfaces-check-no-buildretain 21 and 18 historical findings, respectively. Offending first-party sources, missing interfaces, and tool/dependency pins were checked against the parent of refactor(L1): merge SuperchainConfig into SystemConfig #432. These baseline naming/interface repairs are outside this revert.Generated with Toshi