Repository navigation
Conversation
Advance per-segment cutoffs through historical time at a configurable rate, anchored to committed progress and capped by the retention window. Keep the existing pruning worker and execution limits unchanged. Amp-Thread-ID: https://ampcode.com/threads/T-e489dc29-8527-4793-8a99-1c451c24fd73 Co-authored-by: Julian Meyer <julian.meyer@coinbase.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opt-in experiment for the Base Denim 2s → 200ms pruning transition. Replace distance-configured history cutoffs with timestamp-based retention while keeping the existing pruning worker, scheduling, and execution limits. This is not a pruning work/time budget.
Enable in
reth.toml, alongside the existing distance modes:Snapshot trial: based on Base’s pinned
base-v2.5.2.7release branch. Testing in Base requires rebuilding with this Reth branch and enabling the config; this PR does not update Base’s dependency pin, publish binaries, or modify snapshots. Snapshot consumers need a compatible binary and the enabled config as well as database metadata/checkpoints. Seven days of excess history takes about 23 days to eliminate at 130%. Historical-time advancement is not CPU usage, and fast catch-up can still produce long prune runs. Removing the policy restores block-distance pruning and can cause a catch-up cliff.Validation: 222 pruning/config/stages/type tests passed (one existing ignored), plus the receipt-write regression passed across storage V1/V2. The real-database transition test advances 50 new 200ms blocks while pruning six old 2s blocks per history segment, survives restarts, and converges. Node/CLI all-target compilation, targeted all-target Clippy with
-D warnings, and pinned nightly formatting passed. Workspace all-features Clippy is blocked by missing LLVM 22.1. Snapshot throughput and persistence-backpressure behavior are not yet benchmarked.Test command:
Implementation discussion