fix: enforce native Windows bundle retention safely - #417
Merged
codeforester merged 41 commits intoOct 5, 2026
Merged
codeforester merged 41 commits into
codeforester merged 41 commits into
Conversation
…07-us-record-about-20x-stdlib' into bug/378-20261003-bug-run-bundle-retention-is-inoperative-on-native-windows
…ff-check-and-mypy-do-not-cover-the-compatibility-consum
…-compatibility-consum' into bug/387-20261003-bug-configure-logger-closes-consumer-owned-handlers-and-forc
…wned-handlers-and-forc' into enhancement/381-20261003-perf-lifecycle-logging-costs-107-us-record-about-20x-stdlib
…07-us-record-about-20x-stdlib' into bug/378-20261003-bug-run-bundle-retention-is-inoperative-on-native-windows
…07-us-record-about-20x-stdlib' into bug/378-20261003-bug-run-bundle-retention-is-inoperative-on-native-windows
…-compatibility-consum' into bug/387-20261003-bug-configure-logger-closes-consumer-owned-handlers-and-forc
…wned-handlers-and-forc' into enhancement/381-20261003-perf-lifecycle-logging-costs-107-us-record-about-20x-stdlib
…07-us-record-about-20x-stdlib' into bug/378-20261003-bug-run-bundle-retention-is-inoperative-on-native-windows
…wned-handlers-and-forc' into enhancement/381-20261003-perf-lifecycle-logging-costs-107-us-record-about-20x-stdlib
…07-us-record-about-20x-stdlib' into bug/378-20261003-bug-run-bundle-retention-is-inoperative-on-native-windows
codeforester
added a commit
that referenced
this pull request
Oct 4, 2026
This was referenced Oct 4, 2026
codeforester
commented
Oct 5, 2026
codeforester
left a comment
codeforester
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed against #378's acceptance criteria. The new guards cover the POSIX side: _directory_open_flags raises OSError instead of AttributeError, there's one warning per pass, and the simulated dir_fd-less test is in place. The Windows fallback is a reasonable design. CI is green, and the Windows runner exercises test_native_count_bound_is_enforced.
There are two concerns about the Windows pinning code, inline. The first matters because the docs and comments promise a TOCTOU guarantee that I don't think the code delivers.
…fecycle-logging-costs-107-us-record-about-20x-stdlib' into bug/378-20261003-bug-run-bundle-retention-is-inoperative-on-native-windows
…ff-check-and-mypy-do-not-cover-the-compatibility-consum
…d-mypy-do-not-cover-the-compatibility-consum' into bug/387-20261003-bug-configure-logger-closes-consumer-owned-handlers-and-forc # Conflicts: # docs/integrations.md
…ogger-closes-consumer-owned-handlers-and-forc' into enhancement/381-20261003-perf-lifecycle-logging-costs-107-us-record-about-20x-stdlib
…fecycle-logging-costs-107-us-record-about-20x-stdlib' into bug/378-20261003-bug-run-bundle-retention-is-inoperative-on-native-windows
Contributor
Author
|
Re-verified at |
Base automatically changed from
enhancement/381-20261003-perf-lifecycle-logging-costs-107-us-record-about-20x-stdlib
to
main
October 5, 2026 14:55
codeforester
deleted the
bug/378-20261003-bug-run-bundle-retention-is-inoperative-on-native-windows
branch
October 5, 2026 15:14
codeforester
added a commit
that referenced
this pull request
Oct 5, 2026
Retention now acquires its maintenance lock without waiting on both POSIX and Windows. Contending invocations skip the pass; subsequent successful passes enforce the existing bounds. Teardown acquires the lock before scanning, and lock cleanup never unlocks an unacquired lock. Fixes #386. ## Branch maintenance Refs #426. Targets the branch for #417. Retarget and refresh after that parent is squash-merged; preserve the ordered stack. The branch was refreshed without rewriting history to include `main` at `a576cc279739eae5e4cfc33ffab2a7fb56de24de`. ## Current-head validation At `c4af745a971534dd8ccb13fe51da250ece0d36d7`: uv lock freshness and baseline, runtime, strict typing, style, and contracts passed locally with all declared extras. Runtime result: 621 passed, 1 warning, 262 subtests passed in 8.67s. Hosted checks: 7/7 required checks passed; 0 checks pending; 0 unsuccessful checks at 2026-10-04T14:19:40.760978+00:00. See the PR Checks tab and #426 for subsequent results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run-bundle retention now has a native Windows removal path that pins directory ancestors, refuses reparse points and volume crossings, and preserves existing lease/metadata checks. POSIX keeps descriptor-relative deletion. Unsupported platforms skip the pass with one warning, and absent directory flags raise a handled error.
Fixes #378.
Branch maintenance
Refs #426. Targets the branch for #416. Retarget and refresh after that parent is squash-merged; preserve the ordered stack.
The branch was refreshed without rewriting history to include
mainata576cc279739eae5e4cfc33ffab2a7fb56de24de.Current-head validation
At
e82ce1fbfd7fd3675e8d703a027840d1a82d44bb: uv lock freshness and baseline, runtime, strict typing, style, and contracts passed locally with all declared extras. Runtime result: 620 passed, 1 warning, 262 subtests passed in 8.74s.Hosted checks: 7/7 required checks passed; 0 checks pending; 0 unsuccessful checks at 2026-10-04T14:19:40.760978+00:00. See the PR Checks tab and #426 for subsequent results.