Skip to content

Fix compact hidden Scene Objects rows - #27

Merged
bconnell merged 8 commits into
mainfrom
work/golden-path-ui-20261010
Oct 11, 2026
Merged

bconnell merged 8 commits into
mainfrom
work/golden-path-ui-20261010

Conversation

@bconnell

@bconnell bconnell commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Keep hidden Scene Objects on a readable one-line row with the canonical name first and an explicit [Hidden] marker; long display names are bounded without changing scene identity.
  • Keep rendered row geometry and hit testing on the same production row rectangle.
  • Add bounded automation-only product observations and package-checker logic that reaches the supported compact state through real hide, divider, pager, and row-click interactions. The harness does not select objects or synthesize layout state.
  • Extract Scene Objects packaged validation into a reusable helper and add formatter/layout/log-telemetry regressions.
  • Review follow-up: preserve the full hidden-state suffix with 1–3 name columns; display valid empty names as (unnamed) (or ? when compact); flatten CR/LF for display without changing canonical names.

Validation on exact head

  • Exact source commit: 1efb5ca2cdf5a63476cb636db6ca38497a35855d; clean worktree.
  • Debug and Release henka_tests: 1/1 passed in each configuration.
  • Debug and Release henka_packaged_log_wait_tests: 1/1 passed in each configuration.
  • Fresh Debug Sandbox build and package; build manifest and package marker record the exact clean source SHA and matching executable hashes.
  • Packaged 1280×720 ProductStartupPrimitiveOnly workflow passed. Real hide actions, divider resize, pager navigation and the bounded row-derived adjustment produced one-line named hidden rows; real row clicks changed authoritative selection to the exact hidden canonical entities.
  • Repository integrity, public-content hygiene, documentation truth/local-link, and committed git diff --check passed.

A minimal local capture remains under the canonical Henka _local build root; no machine-specific evidence or generated package files are included in the PR.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T00:58:32.889427Z 84f13cc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84f13cc985

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread examples/sandbox3d/editor_layout.c Outdated
Comment thread examples/sandbox3d/editor_layout.c Outdated
@bconnell
bconnell merged commit b311915 into main Oct 11, 2026
6 checks passed
@bconnell
bconnell deleted the work/golden-path-ui-20261010 branch October 11, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant