Skip to content

fix(camera): preserve fractional viewport zoom deltas - #28

Merged
bconnell merged 1 commit into
mainfrom
work/golden-path-camera-scroll-20261010
Oct 11, 2026
Merged

bconnell merged 1 commit into
mainfrom
work/golden-path-camera-scroll-20261010

Conversation

@bconnell

Copy link
Copy Markdown
Owner

Summary

  • Preserve the signed fractional wheel/touchpad delta through the Sandbox viewport camera path instead of reducing every nonzero event to one full notch.
  • Apply bounded magnitude-sensitive orthographic and perspective zoom transactionally; invalid inputs leave camera state unchanged.
  • Add bounded product-process automation diagnostics and a packaged assertion that sends a real 0.25 scroll event and verifies the authoritative camera state changes.

Validation on exact head 8feab039de8592a843267c32e6610620b47ccbc5

  • Focused Debug henka_tests: passed (1/1).
  • Focused Release henka_tests: passed (1/1).
  • Fresh Debug Sandbox build and package: passed; package marker records clean source SHA and executable hash parity.
  • Full check_packaged_sandbox3d_windows.ps1 -NonInteractive -ProductStartupPrimitiveOnly: passed (exit 0), including the fractional-scroll product-state assertion and remaining packaged workflow.
  • Repository integrity, public-content hygiene, and git diff --check: passed.

A pre-existing CMake object-path length warning was observed during build; it did not fail the target and no path gate was weakened.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T03:27:11.847176Z 8feab03 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bconnell
bconnell merged commit 9009674 into main Oct 11, 2026
6 checks passed
@bconnell
bconnell deleted the work/golden-path-camera-scroll-20261010 branch October 11, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant