Skip to content

UI: restore Asset Browser Materials tab workflow - #29

Merged
bconnell merged 3 commits into
mainfrom
work/ui-asset-browser-tabs-20261011
Oct 11, 2026
Merged

bconnell merged 3 commits into
mainfrom
work/ui-asset-browser-tabs-20261011

Conversation

@bconnell

@bconnell bconnell commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Keep the Materials type tab measurable and reachable in the packaged Asset Browser using context-aware text sizing.
  • Report product-owned Materials and Tools rectangles only when the relevant layout changes.
  • Restore Utility navigation through the real Tools control, then wait for the real Terrain tab geometry before continuing the packaged workflow.
  • Add narrow-width layout regressions including a failure control that verifies outputs remain unchanged.

Validation

  • Feature/package candidate 12e675f4f7a630b14f68d882916410150c54a64b: clean Release Sandbox build and package; package marker and executable SHA-256 matched; full packaged editor workflow passed.
  • Test-only follow-ups ff21e83b6ae99175c3f199bcacb381d0a683556e and b18afa78d8ca65404275a91e892d488573522729 change only tests/test_sandbox3d_editor_layout.c. The insufficient-width failure now compares x/y/width/height for every output rectangle and verifies zero output count; the final assertion uses exact equality for the integral finite sentinels.
  • Red control: temporarily mutating an unchecked output y-coordinate made the strengthened regression fail; the temporary production mutation was removed before commit.
  • Focused Debug and Release henka_tests passed on exact commit b18afa78d8ca65404275a91e892d488573522729; its build provenance records that commit and a clean source state.
  • Both hosted Windows runs for prior PR head ff21e83b6ae99175c3f199bcacb381d0a683556e completed green (push and pull-request events).
  • Fresh hosted Windows checks for current PR head b18afa78d8ca65404275a91e892d488573522729 are running for both push and pull-request events. Exact-head checks remain required before merge.
  • No inline review comments or submitted reviews are currently present.

No generated evidence is committed.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T05:43:12.736944Z 12e675f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bconnell
bconnell merged commit 105c13c into main Oct 11, 2026
6 checks passed
@bconnell
bconnell deleted the work/ui-asset-browser-tabs-20261011 branch October 11, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant