Skip to content

Add Asset Browser search - #31

Merged
bconnell merged 4 commits into
mainfrom
work/asset-browser-search-20261011
Oct 11, 2026
Merged

bconnell merged 4 commits into
mainfrom
work/asset-browser-search-20261011

Conversation

@bconnell

@bconnell bconnell commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Add case-insensitive ASCII search over the currently selected Asset Browser type, matching display names and source paths.
  • Keep filtering, page counts, and selectable rows owned by the production Asset Browser state.
  • Add a real Clear action and focused coverage for type-scoped filtering, paths, no matches, pagination, and compatibility.
  • Extend packaged UI automation to enter a search through real input, verify reduced results and empty results, select a filtered row through product-owned geometry, and clear the search.
  • Ensure filtering does not re-emit path-bearing row diagnostics and that clearing a filter restores the current page summary without an expected UI-owned pointer event replacing it with a viewport warning.
  • Document the session-only search behavior.

Validation for exact head 1607cdd4b10ad249fa8e345d00667442e30c2a82

  • Debug Sandbox build: passed.
  • Debug focused henka_tests: passed, 1/1.
  • Release focused henka_tests: passed, 1/1.
  • Clean Release build provenance and packaged executable both identify this commit; executable SHA-256 3ea1ec98e71ba64cc1d809b5272832836a2e6d61bf299fa703681273f2f1ed08 matches.
  • Full packaged Sandbox workflow: passed, including Asset Browser filtering/no-match/Clear and real row selection, plus authoring, persistence, Game, and shading workflows.
  • Documentation truth and its negative controls, public-content hygiene, repository integrity, and git diff --check: passed.
  • Broad Debug CTest was not fully green: 108/109 passed; henka_showcase_asset_generator_tests exceeded its registered 300-second limit. The isolated generator subsequently completed in about 305 seconds with an extended diagnostic bound on the same source content. This remains a classified validation-timeout finding, not a full-suite pass.
  • Exact-head hosted Windows CI for this SHA is queued (run 38138194274).
  • No review submissions or inline review threads were present when this head was pushed.

This PR contains one focused Asset Browser search slice.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T10:45:34.001360Z 133cb37 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bconnell
bconnell merged commit dab197e into main Oct 11, 2026
6 checks passed
@bconnell
bconnell deleted the work/asset-browser-search-20261011 branch October 11, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant