Repository navigation
fix: the Python matrix and classifiers cover the whole supported range - #25
Merged
Merged
Conversation
The unit-test matrix was [min, "3.12", "3.13"]: a render with 3.12 as its minimum tested 3.12 twice, one with 3.14 tested two versions below its own floor, and nothing ran on 3.14. The classifiers named only the minimum, and coverage was uploaded from 3.12 alone, so a render with a higher minimum uploaded none. Both lists now run from python_min_version to python_max_version, a hidden copier.yml value (3.14) raised in one place. Coverage goes up from the newest version. python_min_version is validated: a 3.x from 3.10 to python_max_version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated unit-test matrix was
["{{ python_min_version }}", "3.12", "3.13"]. With 3.12 as the minimum it tested 3.12 twice. With 3.14 it tested 3.12 and 3.13, below the project's ownrequires-python, and with any minimum nothing ran on 3.14, which every library in the org tests. The classifiers listed only the minimum, and the Codecov upload was tied to 3.12, so a render with a higher minimum uploaded nothing.Both lists are now generated from
python_min_versiontopython_max_version. The latter is a hidden value incopier.yml(when: false, so it is not asked and not written to the answers file), set to 3.14: the next Python is one line. Coverage is uploaded from the newest version.python_min_versiongets a validator, a 3.x from 3.10 to the max; 3.10 is the floor because redis-client-kit uses it.I kept the max at 3.14, not 3.15: pg-partsmith#121 shows that a dependency set still needs bumps (greenlet, pywin32) before 3.15 installs everywhere, and a fresh render resolves whatever is newest.
Renders of this branch:
The answers file of a render has no
python_max_version. actionlint 1.7.12 on the rendered workflows: only the two knownclient-idfindings in release-please.yml.Found while porting the template fixes into the libraries.