Repository navigation
fix: setup_repo.py keeps the repository name after the release App check - #26
Merged
Merged
Conversation
The loop over the App's variable and secret reused `name`, the repository name, as its loop variable. After it, the Trusted Publisher hint printed RELEASE_PLEASE_APP_PRIVATE_KEY as the project and the repository, and a repository with Pages and no homepage would get https://<org>.github.io/RELEASE_PLEASE_APP_PRIVATE_KEY/ as its homepage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#23 added a loop over the release App's variable and secret that used
nameas its loop variable.nameis already the repository name inmain(), so everything after the loop sawRELEASE_PLEASE_APP_PRIVATE_KEYinstead.Re-running the script on idempotency-kit today printed:
The same variable builds the homepage for a repository that has Pages and no homepage yet:
https://<org>.github.io/RELEASE_PLEASE_APP_PRIVATE_KEY/. That never fired on an existing library, because they all have a homepage. A new library set up after #23 would have got it.The loop variable is now
setting.