Repository navigation
fix(setup): protect a new GitLab hub's default branch while GitLab still protects it - #28
Merged
Merged
Conversation
…ill protects it GitLab protects a new project's default branch from a background job, so setup's read of the protection may answer 404 and its POST then meets the protection (409 Protected branch already exists): setup failed the default-branch step. On a 409 it now reads the protection again and goes on as for a branch it found protected. Seen on the GitLab template stand of v0.5.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitLab protects a new project's default branch from a background job. setup's read of the protection could answer 404, and its POST then met the protection (409 "Protected branch already exists"), failing the default-branch step. This happened on the GitLab template stand of v0.5.0.
On a 409 setup now reads the protection again and goes on as for a branch it found protected: it leaves it when it already keeps pushes to No one and merges to Maintainers, and changes it otherwise.
TestGitLabLateProtection plays the race in the fake: the first read misses the protection.