Repository navigation
ci: Release Please opens the release PR with the org's release App - #33
Merged
Merged
Conversation
With GITHUB_TOKEN the release PR's CI run is held and never starts, so it needed a close and reopen before every merge. The token now comes from the org's release App (bedrock-python/python-library-template#23), with GITHUB_TOKEN and a warning as the fallback while the App's variable is unset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one part of the python-library-template release fixes that applies here. touchmark's publish.yml and gate already have their own equivalents of the rest.
Release Please ran with
GITHUB_TOKEN, and GitHub holds the CI run of a pull request opened or updated with that token, so the release PR never got its required check until someone closed and reopened it. It now mints a token of the org's release App (bedrock-python-release, set up today: org variableRELEASE_PLEASE_APP_CLIENT_ID, org secretRELEASE_PLEASE_APP_PRIVATE_KEY), scoped to contents and pull requests. If the variable is unset it falls back toGITHUB_TOKENand warns. The step is the template's (bedrock-python/python-library-template#23), with the action pinned by SHA like the rest of this repo's workflows.Nothing else listens to the releases or tags this creates: publish.yml is still triggered by
workflow_runof Release Please, so the App's token does not add a second trigger.Checked: actionlint 1.7.12 (the CI image) is clean. The same token step ran green in pg-partsmith's Release Please today (run 39071978602).