Repository navigation
[Feat/#105] 학생회비 계좌 송금 플로우 화면 구현 #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xeoxxn
wants to merge
20
commits into
main
Choose a base branch
from
feat/#105-fee-transfer-flow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
94c4211
fix: 공용 모달·결과 화면 설명의 줄바꿈이 무시되는 문제 수정
xeoxxn 5a87bd5
chore: 학생회비 송금 플로우 에셋과 색상 토큰 추가
xeoxxn f5f4c18
feat: 학생회비 계좌 송금 플로우 화면 구현
xeoxxn d9fbf5b
fix: 캡처 예시 이미지를 고해상도로 교체하고 타이포 variant 수정
xeoxxn 7a6cceb
feat: 토스 송금 딥링크 연결
xeoxxn d4c6db2
Revert "feat: 토스 송금 딥링크 연결"
xeoxxn e637bd3
fix: 캡처 예시 카드가 375px 밖에서 그림이 잘리던 문제 수정
xeoxxn 966e826
docs: 송금 플로우 일러스트의 미구현 모션을 코드에 명시
xeoxxn 9ef1160
feat: 송금 플로우 일러스트에 Lottie 모션 적용
xeoxxn b02d9fd
Merge branch 'main' into feat/#105-fee-transfer-flow
xeoxxn 7e88fd6
refactor: 학생회비 송금 플로우를 useFunnel 퍼널 하나로 묶음
xeoxxn 0de9b62
docs: 계좌 송금 퍼널 구조와 File을 context에 담은 이유 기록
xeoxxn 3120451
Merge branch 'main' into feat/#105-fee-transfer-flow
xeoxxn af6fe47
fix: 토스 열림 판정과 퍼널 탈출 히스토리 처리 수정
xeoxxn e77e3fd
refactor: 외부 링크 여는 처리를 lib로 모으고 단계는 콜백만 받게
xeoxxn 03dfdea
refactor: 캡처 파일을 퍼널 context 한곳에서만 들고 있게
xeoxxn 661a2d1
fix: 플로우로 바로 들어왔을 때 첫 단계 뒤로가기가 먹통이던 문제 수정
xeoxxn f92203e
refactor: 송금 플로우의 px 임의값을 Tailwind 단계로 바꿈
xeoxxn 7a6cfb5
fix: 캡처 미리보기를 열어도 초점이 뒤 화면에 남던 문제 수정
xeoxxn 4fe6126
feat: 홈에서 학생회비 계좌 송금 플로우로 진입
xeoxxn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[a] 마지막 커밋에서 라우트 5개가
/fee/transfer하나 +useFunnel퍼널로 바뀌었는데, PR 본문은 아직 이전 구조(라우트 5개,navigate(..., { state })로 학기 수 전달,FeeTransferTranscriptScreen)로 적혀 있는 것 같습니다. 리뷰하는 분들이 헷갈리지 않도록 본문도 지금 구조로 맞춰주시면 감사하겠습니다!그리고 main이 5커밋 앞서 있어서 이 파일과
fee.ts에서 충돌이 나는 것 같습니다. 라우트 경로/fee/transfer자체는 용어 사전 규칙(회비 납부 → fee)에 맞는 것 같아요.