Repository navigation
Conversation
ofalvai
changed the title
ofalvai
force-pushed
the
remove-vendored-jwt-base64
branch
from
October 27, 2026 20:56
c7d2062 to
670426e
Compare
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the removal of the vendored JWT and Base64 libraries.
No open issues 🎉
What changed in this PR
Removes the vendored JWT and Base64 libraries from CodePush’s iOS source tree and cleans up their Xcode project references, reducing bundled third-party source code.
Changes:
- Deletes JWT implementations, headers, module metadata, documentation, and license file.
- Deletes Base64 encoding helpers and their documentation.
- Removes corresponding file references and top-level groups from the Xcode project.
| File | Description |
|---|---|
ios/CodePush/JWT/README.md |
Removes vendored JWT documentation. |
ios/CodePush/JWT/LICENSE |
Removes the vendored JWT license file. |
ios/CodePush/JWT/Core/Supplement/JWTErrorDescription.m |
Removes JWT error descriptions. |
ios/CodePush/JWT/Core/Supplement/JWTErrorDescription.h |
Removes JWT error declarations. |
ios/CodePush/JWT/Core/Supplement/JWTDeprecations.h |
Removes JWT deprecation macros. |
ios/CodePush/JWT/Core/Supplement/JWTBase64Coder.m |
Removes JWT Base64 conversion helpers. |
ios/CodePush/JWT/Core/Supplement/JWTBase64Coder.h |
Removes conversion helper interfaces. |
ios/CodePush/JWT/Core/FrameworkSupplement/Map.modulemap |
Removes the JWT module definition. |
ios/CodePush/JWT/Core/FrameworkSupplement/JWT.h |
Removes the JWT umbrella header. |
ios/CodePush/JWT/Core/Coding/JWTCoding+VersionTwo.m |
Removes version-two JWT coding logic. |
ios/CodePush/JWT/Core/Coding/JWTCoding+VersionTwo.h |
Removes version-two coding interfaces. |
ios/CodePush/JWT/Core/Coding/JWTCoding+VersionThree.m |
Removes version-three JWT coding logic. |
ios/CodePush/JWT/Core/Coding/JWTCoding+VersionThree.h |
Removes version-three coding interfaces. |
ios/CodePush/JWT/Core/Coding/JWTCoding+VersionOne.m |
Removes legacy JWT coding logic. |
ios/CodePush/JWT/Core/Coding/JWTCoding+VersionOne.h |
Removes legacy coding interfaces. |
ios/CodePush/JWT/Core/Coding/JWTCoding+ResultTypes.m |
Removes coding result implementations. |
ios/CodePush/JWT/Core/Coding/JWTCoding+ResultTypes.h |
Removes coding result interfaces. |
ios/CodePush/JWT/Core/Coding/JWTCoding.m |
Removes the base JWT implementation. |
ios/CodePush/JWT/Core/Coding/JWTCoding.h |
Removes base JWT declarations and options. |
ios/CodePush/JWT/Core/ClaimSet/JWTClaimsSetVerifier.m |
Removes claims verification logic. |
ios/CodePush/JWT/Core/ClaimSet/JWTClaimsSetVerifier.h |
Removes claims verifier declarations. |
ios/CodePush/JWT/Core/ClaimSet/JWTClaimsSetSerializer.m |
Removes claims serialization logic. |
ios/CodePush/JWT/Core/ClaimSet/JWTClaimsSetSerializer.h |
Removes claims serializer declarations. |
ios/CodePush/JWT/Core/ClaimSet/JWTClaimsSet.m |
Removes the claims-set implementation. |
ios/CodePush/JWT/Core/ClaimSet/JWTClaimsSet.h |
Removes the claims-set interface. |
ios/CodePush/JWT/Core/ClaimSet/JWTClaim.m |
Removes individual claim validators. |
ios/CodePush/JWT/Core/ClaimSet/JWTClaim.h |
Removes claim validation declarations. |
ios/CodePush/JWT/Core/Algorithms/RSFamily/RSKeys/JWTCryptoSecurity.m |
Removes key and certificate utilities. |
ios/CodePush/JWT/Core/Algorithms/RSFamily/RSKeys/JWTCryptoSecurity.h |
Removes security utility declarations. |
ios/CodePush/JWT/Core/Algorithms/RSFamily/RSKeys/JWTCryptoKeyExtractor.m |
Removes cryptographic key extractors. |
ios/CodePush/JWT/Core/Algorithms/RSFamily/RSKeys/JWTCryptoKeyExtractor.h |
Removes key extractor interfaces. |
ios/CodePush/JWT/Core/Algorithms/RSFamily/RSKeys/JWTCryptoKey.m |
Removes cryptographic key wrappers. |
ios/CodePush/JWT/Core/Algorithms/RSFamily/RSKeys/JWTCryptoKey.h |
Removes key wrapper interfaces. |
ios/CodePush/JWT/Core/Algorithms/RSFamily/JWTRSAlgorithm.h |
Removes asymmetric algorithm protocols. |
ios/CodePush/JWT/Core/Algorithms/RSFamily/JWTAlgorithmRSBase.m |
Removes RSA signing and verification logic. |
ios/CodePush/JWT/Core/Algorithms/RSFamily/JWTAlgorithmRSBase.h |
Removes RSA algorithm declarations. |
ios/CodePush/JWT/Core/Algorithms/HSFamily/JWTAlgorithmHSBase.m |
Removes HMAC algorithm implementations. |
ios/CodePush/JWT/Core/Algorithms/HSFamily/JWTAlgorithmHSBase.h |
Removes HMAC algorithm declarations. |
ios/CodePush/JWT/Core/Algorithms/Holders/JWTAlgorithmDataHolderChain.m |
Removes algorithm-holder chain logic. |
ios/CodePush/JWT/Core/Algorithms/Holders/JWTAlgorithmDataHolderChain.h |
Removes holder-chain declarations. |
ios/CodePush/JWT/Core/Algorithms/Holders/JWTAlgorithmDataHolder.m |
Removes algorithm and key data holders. |
ios/CodePush/JWT/Core/Algorithms/Holders/JWTAlgorithmDataHolder.h |
Removes data-holder interfaces. |
ios/CodePush/JWT/Core/Algorithms/ESFamily/JWTAlgorithmESBase.m |
Removes elliptic-curve algorithm scaffolding. |
ios/CodePush/JWT/Core/Algorithms/ESFamily/JWTAlgorithmESBase.h |
Removes elliptic-curve algorithm declarations. |
ios/CodePush/JWT/Core/Algorithms/Base/JWTAlgorithmNone.m |
Removes the unsigned-token algorithm. |
ios/CodePush/JWT/Core/Algorithms/Base/JWTAlgorithmNone.h |
Removes unsigned-token algorithm declarations. |
ios/CodePush/JWT/Core/Algorithms/Base/JWTAlgorithmFactory.m |
Removes algorithm selection logic. |
ios/CodePush/JWT/Core/Algorithms/Base/JWTAlgorithmFactory.h |
Removes algorithm factory declarations. |
ios/CodePush/JWT/Core/Algorithms/Base/JWTAlgorithm.h |
Removes the shared algorithm protocol. |
ios/CodePush/Base64/README.md |
Removes vendored Base64 documentation. |
ios/CodePush/Base64/Base64/MF_Base64Additions.m |
Removes Base64 codecs and Foundation extensions. |
ios/CodePush/Base64/Base64/MF_Base64Additions.h |
Removes Base64 helper declarations. |
ios/CodePush.xcodeproj/project.pbxproj |
Removes vendored file references and top-level groups. |
Review effort: Balanced
ofalvai
force-pushed
the
remove-vendored-jwt-base64
branch
from
October 28, 2026 10:31
670426e to
4ed4bce
Compare
ofalvai
force-pushed
the
remove-vendored-jwt-base64
branch
from
October 28, 2026 10:43
4ed4bce to
220ddb1
Compare
ofalvai
force-pushed
the
remove-vendored-jwt-base64
branch
from
October 28, 2026 10:50
220ddb1 to
d57580f
Compare
ofalvai
marked this pull request as ready for review
October 28, 2026 12:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of the stack that removes the
JWTandBase64pods (see #94).This PR deletes
ios/CodePush/JWT/andios/CodePush/Base64/and their references inios/CodePush.xcodeproj. Nothing compiled these copies. The podspec globios/CodePush/*.{h,m}is not recursive, and CocoaPods pulled the real pods. After #95, nothing uses them at all.🤖 Generated with Claude Code