Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the rollback-info declaration rename.
No open issues 🎉
What changed in this PR
Corrects the iOS rollback-info method declaration to match the existing implementation, resolving the -Wincomplete-implementation warning without changing runtime behavior.
Changes:
- Renames
+getRollbackInfoto+getLatestRollbackInfoin the public header.
| File | Description |
|---|---|
ios/CodePush/CodePush.h |
Aligns the rollback-info declaration with the implemented method name. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodePush.hdeclares+getRollbackInfo, but nothing implements it. The method inCodePush.mis+getLatestRollbackInfo, so clang warns with-Wincomplete-implementationin both CocoaPods and SPM builds.The header name is a typo from the original rollback retry feature (microsoft/react-native-code-push#1467). That PR added the declaration and the implementation together, with the same doc comment and different names. The bridge method, the JS caller and Android all use
getLatestRollbackInfo.Renaming a method in the public header is safe here. A call to the old name crashes at runtime with "unrecognized selector", so no working code uses it.
Out of scope
The rollback helpers in the public header (
getLatestRollbackInfo,setLatestRollbackInfo:,getRollbackCountForPackage:fromLatestRollbackInfo:) are internal bookkeeping. Removing them from the header could break consumers, so that needs its own change.🤖 Generated with Claude Code