Skip to content

removed BOOST_NO_STD_ITERATOR_TRAITS from details/permutaiton.hpp - #647

Open
andreacassioli wants to merge 2 commits into
boostorg:developfrom
andreacassioli:remove-BOOST_NO_STD_ITERATOR_TRAITS-detail-permutation-hpp
Open

andreacassioli wants to merge 2 commits into
boostorg:developfrom
andreacassioli:remove-BOOST_NO_STD_ITERATOR_TRAITS-detail-permutation-hpp

Conversation

@andreacassioli

@andreacassioli andreacassioli commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Important

New algorithms and API additions need a design issue first. Such a PR is not reviewed until an issue has settled the API and frozen the scope. PRs whose scope grows under review go stale. See How To Contribute an Algorithm.

Motivation

Part of #593

What this PR does

Remove BOOST_NO_STD_ITERATOR_TRAITS from details/permutation.hpp

(I also replace some typedef with using, hope it is ok)

Before submitting

  • I searched for an existing PR or issue covering the same change.
  • This PR targets the develop branch.
  • My contribution is licensed under the Boost Software License 1.0.

Kind of change

Tick exactly one. Each kind is reviewed differently, so mixing them in one PR makes the diff difficult to review (why).

  • Reformat (layout only, no token added or removed)
  • Refactor (no observable behavior change)
  • Behavior change (observable to users of the library)
  • No code change (documentation, build, CI, or tooling)

Change category

  • Bug fix
  • New algorithm or API addition
  • Deprecation or removal
  • Performance
  • Tests
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

@andreacassioli
andreacassioli marked this pull request as ready for review October 14, 2026 19:54
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 38630964486 vs develop run 38291727273 (1a11c0f13f).

Header-inclusion weights (graph files pulling each direct dependency in):

No header-inclusion-weight changes.

Transitive Boost modules: 47 → 47 (0)

@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 38630964467 vs develop run 38291727442 (1a11c0f13f).

Job Baseline After Delta
macos (clang, 14) 253 253 0
macos (clang, 17) 252 252 0
macos (clang, 20) 252 252 0
ubuntu (clang-19, 14) 253 253 0
ubuntu (clang-19, 17) 252 252 0
ubuntu (clang-19, 20) 252 252 0
ubuntu (clang-19, 23) 252 252 0
ubuntu (gcc-14, 14) 349 349 0
ubuntu (gcc-14, 17) 345 345 0
ubuntu (gcc-14, 20) 345 345 0
ubuntu (gcc-14, 23) 345 345 0
windows_msvc_14_3 (msvc-14.3) 937 937 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant