Repository navigation
Fix redefinition of policy<> when float and double are both unpromoted - #1579
Merged
Merged
Conversation
With promote_double now false, defining BOOST_MATH_PROMOTE_FLOAT_POLICY=false made the forwarding specializations repeat policy<>. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
@ckormanyos : Could you test the fix? |
Member
Thankt Nick. Yes I wil restart my CI job now. See also my rerunning job |
Member
|
Wait a minute... I pull develop branch in my CI/CD job. So of course it simply failed again. That's not relevant since your changes are not reflected. I need to jump out for another activity. Maybe I can run it locally tonight. If you push to math develop, my CI/CD runs nightly anyway, so we would catch it tomorrow at the latest... |
Collaborator
Author
|
@ckormanyos : Yeah I'll merge it and if doesn't fix you I'll just do another. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With promote_double now false, defining BOOST_MATH_PROMOTE_FLOAT_POLICY=false made the forwarding specializations repeat policy<>.
Reported in #1574 (comment) (regression from #1554).
🤖 Generated with Claude Code