Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
colorlog.basicConfig(handlers=[])raisesIndexErrorafter the standard library accepts the configuration and leaves the root logger without handlers. This also affectshandlers=[], force=Truewhen tearing down an existing configuration.Skip formatter replacement when there is no handler, while holding the existing logging lock. The current nonempty-handler behavior is preserved. Tests cover empty configuration and actual output through a supplied handler.
Validation: the new empty-handler regression fails on main; the full suite passes on Python 3.14 with colorama (37 tests) and Python 3.9 without colorama (35 tests). The documented CI commands for Black, Flake8, and mypy pass. An installed wheel passes empty setup, subsequent stream logging, forced teardown, and replacement-handler output checks. A separate AI reviewer checked the final commit and independently reran all 37 tests. Prepared with AI assistance.