Repository navigation
Conversation
Member
Author
|
Depends on #596. |
vigh-m
approved these changes
Oct 19, 2026
jpculp
marked this pull request as ready for review
October 19, 2026 22:50
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
jpculp
force-pushed
the
use-cross-nvidia-paths-macro
branch
from
October 19, 2026 23:05
7f2adba to
d90cb1e
Compare
Member
Author
|
Re-based for clean checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Switch to a parametrized macro, shared by the nvidia kmod packages in the Bottlerocket SDK (bottlerocket-os/bottlerocket-sdk#394), that defines the branch-namespaced NVIDIA path macros for a given driver branch. It takes the branch as
%1, resolvesnvidia_rootto%{_cross_datadir}/.nvidia/<branch>, and derives the per-branchdatadir/libdir/bindir/sysconfdirglobals from it. Collapses an otherwise duplicated path-definition block down to a single%cross_nvidia_paths <branch>call.Testing done:
Compared
/usr/share/nvidia/contents of the latest AMI and one built using the new macro.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.