Repository navigation
fix: retry transient connection failures for API queries - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheduled integration run failed when its first
get_merequest timed out connecting to Hardcover; the other 22 tests passed. Retry transient network failures in the API client so both the plugin and live tests can recover from this kind of blip.This PR contains only the API retry change and its tests. GitHub Actions runtime/cache upgrades are intentionally excluded.
Validation
uv run pytest --tb=short -q -rs --cov-fail-under=90: 518 passed, including all 23 live API tests; 94.85% coverage.uv run ruff check src/ test/: passed.uv run ruff format --check src/ test/ --exclude src/hardcover_sync/_version.py: passed.uv run pyright src/hardcover_sync/api.py: passed.git diff --check origin/main...HEAD: passed.The full-project local type check has six pre-existing errors outside the changed files; the same errors were reproduced on the unchanged baseline.