Repository navigation
Return error instead of panicking on malformed scriptlet args - #745
Open
starlinker28-spec wants to merge 1 commit into
Open
starlinker28-spec wants to merge 1 commit into
starlinker28-spec wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #432.
get_scriptlet_resourcecalled.unwrap()onparse_scriptlet_args, which returnsNonefor malformed input such as an unclosed quote (e.g.greet, 'unclosed). Sinceget_scriptlet_resourcesis public, any caller passing malformed args could trigger a panic.This now returns a new
ScriptletResourceError::MalformedScriptletArgserror instead.get_scriptlet_resourcesalready skips scriptlets that return an error, so malformed input is ignored rather than crashing.Added a test case to
get_patched_scriptletscovering this; it panics without the fix and passes with it.Note: this adds a variant to the public
ScriptletResourceErrorenum.