Repository navigation
Fix pg-native prepare example output and doc typos - #3823
Merged
Merged
Conversation
The pg-native prepare/execute example aliases the column as `beans`, so the rows are keyed by `beans`, not by the statement name `i_like_beans`. Also correct spelling and wording in the READMEs and upgrading guide: requring -> requiring, compatiblity -> compatibility, exteremly convienent -> extremely convenient, releated -> related, and "documentation or communicate" -> "documentation or communication".
charmander
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pg-native
client.prepare/client.executeexample inpackages/pg-native/README.mdpreparesSELECT $1::text as beans, but the output comment showed the row keyed by the statement name:Rows are keyed by column name, so the result is
[{ "beans": "Brak" }].packages/pg-native/test/query-async.jschecks the same thing: it preparesSELECT $1::text as nameand assertsrows[0].name.Also fixes a few typos:
README.md: requring -> requiringdocs/pages/guides/upgrading.md: compatiblity -> compatibilitypackages/pg-native/README.md: exteremly convienent -> extremely convenientpackages/pg-pool/README.md: releated -> relatedpackages/pg/README.md: "documentation or communicate it will require" -> "documentation or communication it will require" (matches the root README)Docs only, no code changes.