Repository navigation
fix(pg-cloudflare): emit close after the socket's closed promise rejects - #3824
Open
Saadanjum0 wants to merge 1 commit into
Open
Saadanjum0 wants to merge 1 commit into
Saadanjum0 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3822
When the Cloudflare socket's
closedpromise rejects,CloudflareSocketemitserrorbut neverclose.Connectiononly emitsendon the stream'sclose, soclient.end()on that connection never resolves. workerd can also rejectclosedwithundefined, which then reachesreportStreamErrorinpg/lib/connection.jsand throws onerror.code.The fix makes the rejection path in
_addClosedHandler()behave likenet.Socket: emiterror(wrapping anundefinedrejection in anError), then emitcloseif that socket is still the current one. The_cfSocket === socketcheck is the same one the resolve path andend()already use, socloseis still emitted at most once.Testing: added a case to
pg-esm-test/pg-cloudflare.test.jsthat rejectsclosedwithundefinedand expects anErrorfollowed byclose. It fails on master (noclosewithin the timeout) and passes with this change. The rest of the pg-cloudflare tests pass, and eslint and prettier are clean on the touched files.