Repository navigation
fix: preserve UTF-8 across shell output chunks - #360
Merged
Merged
Conversation
frostming
marked this pull request as ready for review
October 15, 2026 04:27
frostming
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve UTF-8 characters when shell output splits them across reads.
ShellManager._drain_stream()currently decodes each 4096-byte chunk independently witherrors="replace". A valid multibyte character spanning two reads becomes replacement characters, so shell tool output can corrupt non-ASCII text and filenames.Use a separate incremental UTF-8 decoder for each stdout/stderr reader, and flush it at EOF. Invalid bytes and incomplete trailing sequences still use replacement decoding. There are no new dependencies or changes to the shell API.
Reproduction
Run a shell command that writes
b"a" * 4095 + "中".encode("utf-8")to stdout or stderr. On the base revision, the final character is returned as replacement characters. With this change, the original text is preserved.Tests
make check: passed, including lock validation, all pre-commit hooks, and mypy (57 source files).traceextra installed:HOME=/tmp/bub-test-home OTEL_TRACES_SAMPLER=always_on .venv/bin/python -m pytest --doctest-modules: 613 passed, 1 skipped (PowerShell unavailable). The sampler override prevents the host’s inherited sampling setting from disabling the in-memory tracing assertions.