Repository navigation
Send BSR module names to check plugins - #4718
Merged
Merged
Conversation
If available, pass BSR module names to check plugins as additional context. If the name in buf.yaml isn't a valid module name (fails protovalidate), ignore it and omit the module name. Add an e2e test that verifies that module names make it to check plugins.
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
pkwarren
commented
Oct 6, 2026
| name: buf.build/acme/weather | ||
| - path: unnamed | ||
| - path: invalid | ||
| name: buf.build/acme/x |
Member
Author
There was a problem hiding this comment.
This is accepted as a name for local development but will fail if pushed to the BSR. https://github.com/bufbuild/bufplugin/blob/30a1a690760135168833b86885cebc29e83717ae/buf/plugin/descriptor/v1/module_name.proto#L29-L35 constrains this value.
| var fileAnnotationSet bufanalysis.FileAnnotationSet | ||
| if !errors.As(err, &fileAnnotationSet) { | ||
| if errors.Is(err, context.Canceled) || ctx.Err() != nil { | ||
| if errors.Is(err, context.Canceled) { |
Member
Author
There was a problem hiding this comment.
Can remove this workaround now that pluginrpc/pluginrpc-go#17 has landed upstream.
pkwarren
changed the title
emcfarlane
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If available, pass BSR module names to check plugins as additional context. If the name in buf.yaml isn't a valid module name (fails protovalidate), ignore it and omit the module name.
Add an e2e test that verifies that module names make it to check plugins.