Repository navigation
Conversation
Contributor
|
I believe that this problem should be fixed by #228 can you verify? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NativeCompilercompiles on a fixed thread pool that is never shut down, meaning you just now have an active JVM running in the background while this goes. Once anything had been compiled at runtime, those threads kept the JVM alive after the application finished. I ran into this as a Minecraft client that hung on quit after loading a mod through Redline.The pool now uses a thread factory that makes daemon threads named
redline-compiler. Compilation works the same way; the threads just no longer keep a finished JVM running. I didn't add a test for this, since checking that a JVM exits needs a separate process, but I can add one if you'd like.