Repository navigation
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
View guided diff | Turn on auto-fix | Re-trigger cubic
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…me folder createAgentDeviceRuntime and the command-surface binding over it are the in-process runtime assembly #3288 already classifies as command-runtime. They now live under src/command-runtime/, where topFolder derives that zone from the folder instead of per-file ROOT_MODULE_ZONES rows. Both files move as one group: the surface file composes the factory's result, and neither is importable from the other's consumers separately. Importers (src/runtime.ts and the daemon runtime modules) re-point.
The rows and prose claim only this change's collocation; the diagnostics-scope wording inherited from #3297 is left untouched.
…ONES Both files now live under src/command-runtime/, so topFolder derives their command-runtime zone from the folder and the per-file rows are redundant. The drift test proves the declaration matches the tree; the fallow comment follows the moved factory path.
debf68e to
f7c8cc2
Compare
|
No problems found in f7c8cc2. The runtime assembly pair moves into command-runtime as described, with all importers updated and no stale paths. All 14 checks pass, and I know of no conflicts. I did not run the layering scan or the test suite; I checked the layering direction by reading the imports. This PR is stacked on #3297, so please merge #3297 first. |
thymikee
added
the
ready-for-human
|
Thanks — confirmed at |
1 participant
Summary
Second physical root-pass move under #3294 (part of #3276, ADR 0033).
src/runtime-factory.tsandsrc/runtime-command-surface.ts— the in-process runtime assembly and the command-surface binding over it — now live undersrc/command-runtime/, the folder whosecommand-runtimezone #3288 already derived for them logically.topFolderderives the zone from the folder, so both per-fileROOT_MODULE_ZONESrows are deleted in the final commit; folder-derived ownership replaces them, no new registry. They move as one group since the surface file only composes the factory's result. Importers (src/runtime.ts, daemon runtime modules) re-point. Stack order: this PR is stacked on #3297 (its base branch); merge #3297 first, then retarget this tomain(GitHub retargets automatically when the base merges). Refs #3294 (closes when all three root-pass moves land on main).Validation
f7c8cc2e9(onto refactor(move): daemon diagnostics scope into daemon-contracts (#3294) #3297 headf6723c435):pnpm check:affected --run— all runnable checks passed;tsc -p tsconfig.jsonclean; drift test green.git diff -M90% --stat f6723c435...HEADshows both moved files assrc/{ => command-runtime}/…renames with only import-spec line hunks (6 and 2 lines); no material content change (rename-only move PR).root-module-zones.test.tsfails listing both asstale; with the rows removed it passes.src/runtime.tsand the daemon runtime consumers selected by the vitest-related run.package.json#exportsentry;src/runtime.tskeeps re-exporting the published shape.pull/3294would 404).