Skip to content

fix(fab): expose expanded state on the FAB.Menu trigger #5151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ganeshguru5 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(fab): expose expanded state on the FAB.Menu trigger #5151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2573e6e
fix(fab): expose expanded state on the FAB.Menu trigger
Ganeshguru5 Nov 1, 2026
d4efa66
Merge branch 'main' into fix/fab-menu-trigger-aria-expanded
Ganeshguru5 Nov 2, 2026
5bbb78e
test(fab): press the enabled trigger in the expanded state test
Ganeshguru5 Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/FAB/Menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,7 @@ const MorphingTrigger = ({
visible={visible}
onPress={onPress}
aria-label={ariaLabel}
aria-expanded={expanded}
testID={testID}
widthShared={widthShared}
heightShared={heightShared}
Expand Down
17 changes: 17 additions & 0 deletions src/components/__tests__/FABMenu.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,3 +192,20 @@ it('calls onDismiss when trigger is pressed while menu is open', async () => {
await userEvent.press(screen.getByTestId('fab-shell'));
expect(onDismiss).toHaveBeenCalledTimes(1);
});

it('exposes the expanded state on the trigger', async () => {
const menu = (expanded: boolean) => (
<FAB.Menu
expanded={expanded}
onDismiss={jest.fn()}
trigger={{ icon: 'plus', onPress: jest.fn(), 'aria-label': 'Actions' }}
items={makeItems()}
/>
);

await render(menu(false));
expect(screen.getByRole('button', { name: 'Actions' })).toBeCollapsed();

await screen.rerender(menu(true));
expect(screen.getByRole('button', { name: 'Actions' })).toBeExpanded();
});
14 changes: 7 additions & 7 deletions src/components/__tests__/__snapshots__/FABMenu.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ exports[`renders FAB.Menu closed 1`] = `
"busy": undefined,
"checked": undefined,
"disabled": true,
"expanded": undefined,
"expanded": false,
"selected": undefined,
}
}
Expand Down Expand Up @@ -1365,7 +1365,7 @@ exports[`renders FAB.Menu not expanded when trigger is not visible 1`] = `
"busy": undefined,
"checked": undefined,
"disabled": true,
"expanded": undefined,
"expanded": false,
"selected": undefined,
}
}
Expand Down Expand Up @@ -2142,7 +2142,7 @@ exports[`renders FAB.Menu open 1`] = `
"busy": undefined,
"checked": undefined,
"disabled": false,
"expanded": undefined,
"expanded": true,
"selected": undefined,
}
}
Expand Down Expand Up @@ -3623,7 +3623,7 @@ exports[`renders FAB.Menu with 6 items 1`] = `
"busy": undefined,
"checked": undefined,
"disabled": false,
"expanded": undefined,
"expanded": true,
"selected": undefined,
}
}
Expand Down Expand Up @@ -4401,7 +4401,7 @@ exports[`renders FAB.Menu with center alignment 1`] = `
"busy": undefined,
"checked": undefined,
"disabled": false,
"expanded": undefined,
"expanded": true,
"selected": undefined,
}
}
Expand Down Expand Up @@ -5238,7 +5238,7 @@ exports[`renders FAB.Menu with items having icons 1`] = `
"busy": undefined,
"checked": undefined,
"disabled": false,
"expanded": undefined,
"expanded": true,
"selected": undefined,
}
}
Expand Down Expand Up @@ -6015,7 +6015,7 @@ exports[`renders FAB.Menu with start alignment 1`] = `
"busy": undefined,
"checked": undefined,
"disabled": false,
"expanded": undefined,
"expanded": true,
"selected": undefined,
}
}
Expand Down
Loading